Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better usemtl handling #123

Merged
merged 2 commits into from
Dec 29, 2017
Merged

Better usemtl handling #123

merged 2 commits into from
Dec 29, 2017

Conversation

lilleyse
Copy link
Contributor

Fixes #98

@shehzan10
Copy link
Member

@lilleyse Looks fine to me. Does this change warrant having tests? Maybe we can add a test file that meets this case.

@lilleyse
Copy link
Contributor Author

Oh yes there should be a test, I'll add one.

@lilleyse lilleyse force-pushed the usemtl-fix branch 3 times, most recently from 4d9b90c to 5189923 Compare December 29, 2017 16:59
@lilleyse
Copy link
Contributor Author

Updated

@shehzan10 shehzan10 merged commit b017f67 into master Dec 29, 2017
@shehzan10 shehzan10 deleted the usemtl-fix branch December 29, 2017 17:10
lilleyse added a commit that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants