Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove minFilter and magFilter #240

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Remove minFilter and magFilter #240

merged 1 commit into from
Aug 2, 2021

Conversation

lilleyse
Copy link
Contributor

Fixes #239

This lets the runtime engine use the filtering modes they prefer. From the glTF spec:

Default Filtering Implementation Note: When filtering options are defined, runtime must use them. Otherwise, it is free to adapt filtering to performance or quality goals.

@lilleyse lilleyse force-pushed the remove-sampler-filter branch from 59415dd to 3675766 Compare May 11, 2020 13:57
@lilleyse lilleyse mentioned this pull request May 11, 2020
Closed
@lilleyse lilleyse force-pushed the remove-sampler-filter branch from 3675766 to ed52436 Compare August 1, 2021 22:25
@lilleyse lilleyse force-pushed the remove-sampler-filter branch from ed52436 to 4270358 Compare August 1, 2021 22:26
@IanLilleyT IanLilleyT merged commit 3283239 into main Aug 2, 2021
@IanLilleyT IanLilleyT deleted the remove-sampler-filter branch August 2, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minFilter 9986 vs 9987 - Moiré pattern on model viewer
2 participants
@lilleyse @IanLilleyT