Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#89 Docker setup improvements #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#89 Docker setup improvements #90

wants to merge 1 commit into from

Conversation

rodolfobandeira
Copy link
Contributor

  • Run bundle install with 2 jobs (speed up a bit)
  • Adds a bundle cache volume so we don't need to run fresh gem installs every so often

close #89

@rodolfobandeira rodolfobandeira force-pushed the 89-docker-setup-improvements branch from bb19b66 to 6e9a930 Compare October 11, 2021 14:50
@rodolfobandeira rodolfobandeira changed the title Docker setup improvements #89 Docker setup improvements Oct 11, 2021
@ChaelCodes
Copy link
Owner

What do you think about caching the gems in the repo instead? Placing them at vendor/cache so bundler defaults to there. I normally see gems stored that way in codebases that cache them.

@ChaelCodes ChaelCodes added the hacktoberfest-accepted Accepted for Hacktoberfest label Oct 14, 2021
@ChaelCodes ChaelCodes added this to the Hacktoberfest 2021 milestone Nov 1, 2021
@ChaelCodes ChaelCodes added 👑 Heroic 👑 For PRs that demonstrate how something could be done, but ultimately aren't merged/mergeable. and removed hacktoberfest-accepted Accepted for Hacktoberfest hacktoberfest-approved IDK IF IT'S APPROVED OR ACCEPTED. labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
👑 Heroic 👑 For PRs that demonstrate how something could be done, but ultimately aren't merged/mergeable.
Projects
None yet
Milestone
Hacktoberfest 2021
Development

Successfully merging this pull request may close these issues.

Docker setup improvements
2 participants
@rodolfobandeira @ChaelCodes