Skip to content
This repository has been archived by the owner on Jul 13, 2022. It is now read-only.

Change misleading log message #491

Merged
merged 4 commits into from
Aug 6, 2020
Merged

Change misleading log message #491

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4cb6dbe
changing log message
Jul 31, 2020
b146235
addressing feedback
Aug 4, 2020
ddaeb8a
Merge branch 'master' into alex/change-log
Aug 6, 2020
43f6857
Merge branch 'master' into alex/change-log
Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chains/ethereum/writer_methods.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ func (w *writer) watchThenExecute(m msg.Message, data []byte, dataHash [32]byte,
w.executeProposal(m, data, dataHash)
return
} else {
w.log.Trace("Ignoring finalization event", "src", sourceId, "nonce", depositNonce)
w.log.Trace("Did not find the matching finalization event, retrying...", "src", sourceId, "nonce", depositNonce)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
w.log.Trace("Did not find the matching finalization event, retrying...", "src", sourceId, "nonce", depositNonce)
w.log.Trace("Ignoring event, not a finalization event", "src", sourceId, "nonce", depositNonce)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in the issue, they aren't finalization events and they should still be ignored

}
}
w.log.Trace("No finalization event found in current block", "block", latestBlock, "src", m.Source, "nonce", m.DepositNonce)
Expand Down