This repository has been archived by the owner on Jul 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waymobetta
approved these changes
Aug 3, 2021
P1sar
suggested changes
Aug 3, 2021
Go aside, the logic makes sense. Also for reference this is what we do in web3.js |
P1sar
reviewed
Aug 3, 2021
P1sar
approved these changes
Aug 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added in the logic for checking whether the chain has forked to London and sending with the appropriate gas price.
LockAndUpdateOpts
tests whether the header of the most recent block has BaseFee != nil to tell whether we are using London txs. This then updates the GasTipCap and GasFeeCap. GasFeeCap is then used to later when generating a new tx to see whether it should be a LegacyTx or a DynamicFeeTx.There is also a dependency upgrade for
go-ethereum
tov1.10.6
Related Issue Or Context
Example transfer submitted on Goerli can be found here: https://goerli.etherscan.io/tx/0x2b090b74e298434bc9023689060b73787f126b1d511ba7ff375aa51b006605c4
Under TX Type you can see EIP-1559 tx type is used.
Closes: #
How Has This Been Tested? Testing details.
Types of changes
Checklist: