Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove utils/commcid in favor of fvm_shared::commcid #1553

Closed
2 tasks
lemmih opened this issue Jun 21, 2022 · 0 comments · Fixed by #1570
Closed
2 tasks

Remove utils/commcid in favor of fvm_shared::commcid #1553

lemmih opened this issue Jun 21, 2022 · 0 comments · Fixed by #1570
Assignees
@connormullett
Labels
Priority: 3 - Medium Nice-to-have, does not impede core functionality Ready Issue is ready for work and anyone can freely assign it to themselves Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee

Comments

@lemmih
Copy link
Contributor

lemmih commented Jun 21, 2022

Issue summary

  • Update code to use fvm_shared::commcid directly.
  • Remove utils/commcid source code.

Other information and links
@lemmih lemmih added Priority: 3 - Medium Nice-to-have, does not impede core functionality Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee Ready Issue is ready for work and anyone can freely assign it to themselves labels Jun 21, 2022
@connormullett connormullett self-assigned this Jun 22, 2022
@connormullett connormullett mentioned this issue Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connormullett connormullett

Labels
Priority: 3 - Medium Nice-to-have, does not impede core functionality Ready Issue is ready for work and anyone can freely assign it to themselves Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove commcid in favor of the fvm commcid ChainSafe/forest
2 participants
@lemmih @connormullett