Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove commcid in favor of the fvm commcid #1570

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Conversation

connormullett
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Remove Commcid for fvm_shared::commcid

Reference issue to close (if applicable)

Closes #1553

Other information and links

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1570 (24fb4cb) into main (a651add) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
- Coverage   36.21%   36.11%   -0.10%     
==========================================
  Files         220      219       -1     
  Lines       24742    24690      -52     
==========================================
- Hits         8961     8918      -43     
+ Misses      15781    15772       -9     
Impacted Files Coverage Δ
ipld/blockstore/src/buffered.rs 69.23% <ø> (ø)
types/src/verifier/mod.rs 0.00% <ø> (ø)
vm/runtime/src/lib.rs 1.07% <ø> (ø)
blockchain/message_pool/src/msgpool/mod.rs 87.76% <0.00%> (+0.13%) ⬆️
blockchain/message_pool/src/msgpool/msg_pool.rs 65.75% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a651add...24fb4cb. Read the comment docs.

Copy link
Contributor

@elmattic elmattic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the entry in the Makefile that cargo cleans the package.

@lemmih lemmih merged commit 2d94f86 into main Jun 23, 2022
@lemmih lemmih deleted the connor/remove-utils-commcid branch June 23, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove utils/commcid in favor of fvm_shared::commcid
3 participants