Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code from the VM. #1598

Closed
lemmih opened this issue Jun 29, 2022 · 0 comments · Fixed by #1608
Closed

Remove dead code from the VM. #1598

lemmih opened this issue Jun 29, 2022 · 0 comments · Fixed by #1608
Assignees
Labels
Maintenance Priority: 4 - Low Limited impact and can be implemented at any time Ready Issue is ready for work and anyone can freely assign it to themselves Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee

Comments

@lemmih
Copy link
Contributor

lemmih commented Jun 29, 2022

Issue summary

The VM structure contains a bunch of dead code from before the switch to the FVM. It should be removed together with as many of the lifetime variables as possible:

pub struct VM<
'db,
'r,
DB: BlockStore + 'static,
R,
C: CircSupplyCalc,
LB,
V = FullVerifier,
P = DefaultNetworkParams,
> {
_state: Rc<RefCell<StateTree<'db, DB>>>,
_store: &'db DB,
_epoch: ChainEpoch,
_rand: &'r R,
_base_fee: BigInt,
registered_actors: HashSet<Cid>,
_network_version: NetworkVersion,
_circ_supply_calc: C,
fvm_executor: fvm::executor::DefaultExecutor<ForestKernel<DB>>,
_lb_state: &'r LB,
verifier: PhantomData<V>,
params: PhantomData<P>,
heights: Heights,
}

Other information and links

@lemmih lemmih added Priority: 4 - Low Limited impact and can be implemented at any time Maintenance Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee Ready Issue is ready for work and anyone can freely assign it to themselves labels Jun 29, 2022
@tyshko5 tyshko5 self-assigned this Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Priority: 4 - Low Limited impact and can be implemented at any time Ready Issue is ready for work and anyone can freely assign it to themselves Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants