Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code from the VM. #1608

Merged
merged 4 commits into from
Jul 1, 2022
Merged

Remove dead code from the VM. #1608

merged 4 commits into from
Jul 1, 2022

Conversation

tyshko5
Copy link
Contributor

@tyshko5 tyshko5 commented Jul 1, 2022

Summary of changes
Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes #1598

Other information and links

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1608 (71aef0a) into main (c475fa5) will increase coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
+ Coverage   29.41%   29.60%   +0.19%     
==========================================
  Files         194      192       -2     
  Lines       21264    21034     -230     
==========================================
- Hits         6254     6227      -27     
+ Misses      15010    14807     -203     
Impacted Files Coverage Δ
blockchain/state_manager/src/lib.rs 2.45% <0.00%> (ø)
vm/interpreter/src/vm.rs 0.00% <0.00%> (ø)
vm/interpreter/src/gas_tracker/gas_charge.rs 0.00% <0.00%> (-100.00%) ⬇️
blockchain/message_pool/src/msgpool/msg_pool.rs 65.49% <0.00%> (-0.27%) ⬇️
blockchain/message_pool/src/msgpool/mod.rs 87.63% <0.00%> (-0.13%) ⬇️
vm/interpreter/src/fvm/externs.rs 0.00% <0.00%> (ø)
vm/message/src/unsigned_message.rs 68.00% <0.00%> (ø)
vm/interpreter/src/gas_block_store.rs 46.15% <0.00%> (ø)
blockchain/chain_sync/src/tipset_syncer.rs 0.00% <0.00%> (ø)
vm/actor_interface/src/builtin/miner/mod.rs 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c475fa5...71aef0a. Read the comment docs.

vm/interpreter/src/vm.rs Outdated Show resolved Hide resolved
@tyshko5 tyshko5 requested a review from lemmih July 1, 2022 09:15
vm/interpreter/src/vm.rs Outdated Show resolved Hide resolved
@tyshko5 tyshko5 requested a review from lemmih July 1, 2022 09:30
@lemmih lemmih merged commit dba8145 into main Jul 1, 2022
@lemmih lemmih deleted the tyshko5/issue-1598 branch July 1, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dead code from the VM.
4 participants