Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way of choosing StateTree between fvm@3 and fvm@4 #3523

Closed
hanabi1224 opened this issue Sep 27, 2023 · 2 comments · Fixed by #3520
Closed

Find a way of choosing StateTree between fvm@3 and fvm@4 #3523

hanabi1224 opened this issue Sep 27, 2023 · 2 comments · Fixed by #3520

Comments

@hanabi1224
Copy link
Contributor

hanabi1224 commented Sep 27, 2023

Issue summary

StateTree from fvm@3 and fvm@4 both support StateTreeVersion::V5 but are not compatible, when using StateTree from fvm@4, forest panics during nv18-nv20 state migration

thread 'state migration thread: 1' panicked at 'Failed iterating over actor state: StateTree::for_each not supported on old state trees

We need to find a way of deciding which StateTree version to use in StateTree::new and StateTree::new_from_root.

Other information and links

@hanabi1224
Copy link
Contributor Author

It's actually a bug in the shim code, fixed by f616911

@hanabi1224 hanabi1224 linked a pull request Sep 27, 2023 that will close this issue
4 tasks
@lemmih
Copy link
Contributor

lemmih commented Sep 27, 2023

It's actually a bug in the shim code, fixed by f616911

Alright. Closing this issue.

@lemmih lemmih closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants