Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fvm4 shim types #3520

Merged
merged 15 commits into from
Sep 29, 2023
Merged

fvm4 shim types #3520

merged 15 commits into from
Sep 29, 2023

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Sep 27, 2023 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • Implement shim types for fvm@4

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 linked an issue Sep 27, 2023 that may be closed by this pull request
Find a way of choosing StateTree between fvm@3 and fvm@4 #3523
Closed
@hanabi1224 hanabi1224 linked an issue Sep 27, 2023 that may be closed by this pull request
Properly set elapsed field in type convertion logic between GasChargeV3 and GasChargeV4 #3524
Closed
hanabi1224
hanabi1224 commented Sep 27, 2023
View reviewed changes
src/shim/gas.rs Outdated
other_gas: GasV3::from_milligas(value.other_gas.as_milligas()),
// FIXME: https://github.com/ChainSafe/forest/issues/3524
// elapsed: value.elapsed.into(),
elapsed: Default::default(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is not blocking per #3524 (comment)

@hanabi1224 hanabi1224 marked this pull request as ready for review September 27, 2023 12:52
@hanabi1224 hanabi1224 requested a review from a team as a code owner September 27, 2023 12:52
@hanabi1224 hanabi1224 requested review from lemmih and sudo-shashank and removed request for a team September 27, 2023 12:52
@hanabi1224 hanabi1224 changed the title [WIP] fvm4 shim types fvm4 shim types Sep 27, 2023
@LesnyRumcajs
Copy link
Member

@hanabi1224 no green checkmark!

@lemmih
Copy link
Contributor

lemmih commented Sep 27, 2023

ErrorNumber can be radically simplified, but that's for another time.

@hanabi1224
Copy link
Contributor Author

@hanabi1224 no green checkmark!

@LesnyRumcajs Doctest fixed!

@hanabi1224 hanabi1224 mentioned this pull request Sep 28, 2023
Closed
LesnyRumcajs
LesnyRumcajs approved these changes Sep 28, 2023
View reviewed changes
src/shim/clock.rs Outdated Show resolved Hide resolved
src/shim/crypto.rs Outdated Show resolved Hide resolved
src/shim/gas.rs Show resolved Hide resolved
src/tool/subcommands/snapshot_cmd.rs Outdated Show resolved Hide resolved
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit cfc2cdb Sep 29, 2023
@LesnyRumcajs LesnyRumcajs deleted the fvm4 branch September 29, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@lemmih lemmih lemmih approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hanabi1224 @LesnyRumcajs @lemmih