Elmattic/actors review F1 #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in Lotus runtime or in spec actors
elmattic
requested review from
connormullett,
creativcoder and
ec2
as code owners
noot
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
recoverin LotusThis PR introduces a way to distinguish between errors that are directly returned (in an Actor or Runtime code) and errors that are indirectly returned via the Lotus Runtime Abortf function.
In Lotus these latter are recovered in the shimCall that protects a method from panicking when invoked.
Note that this PR only fixes following errors for the multisig actor as a starting point:
Reference issue to close (if applicable)
Closes
#1265
Other information and links
See also:
#857