-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch panic in verify_window_post
#1365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hell ya
Happy to include this in 0.2.0 if you can fix the tests and linter |
e369966
to
a4b409b
Compare
don't merge this yet - updating the rand version causes a state root mismatch |
is there no test for this? |
@q9f not right now, I have to manually sync the node to see if it's compatible with mainnet still. it would be nice to have an automated test for that |
verify_window_post
* ci: run github actions on os matrix * ci: deduplicate github workflows * ci: add nightly workflow * ci: add binary install step * ci: further deduplicate work * ci: purge circleci * ci: run tools on msrv * ci: use gh pages deploy action * scripts: remove docs script * docs: update readme * github: update codeowners * ci: enable codecov * ci: fix syntax * docs: restore badges * ci: purge codecov config * ci: use tarpaulin to gather coverage * ci: move coverage to dedicated job * ci: enable buildjet runners * ci: reduce matrix for testing * ci: fix syntax * make: parallelize tests * ci: ignore clippy::redundant-clone * ci: add dependencies * ci: attempt multiple runners * ci: remove broken cache step * ci: reenable macos * make: fix test * ci: automatically cancel previous runs * blockchain/msgpool: disable flaky test, ref #1369 * ci: increase tarpaulin timeout * ci: add rust caching action * blockchain/msgpool: disable more flaky tests, ref #1369 * blockchain/msgpool: disable more flaky tests, ref #1369 * make: make sure tests run in release mode * blockchain/msg_pool: reenable tests in release mode * ci: remove msrv = stable * make: ignore clippy::to-string-in-format-args * ci: further reduce test threads * ci: add build matrix for low priority jobs * ci: further optimize threads * chore: clean up * cargo: add dev profile without debug symbols * ci: populate environment * ci: fix profile * ci: nit * ci: enable incremental builds * ci: resolve merge of #1365 * ci: progressively cache all rust jobs * ci: fix gh pages action version string * ci: fix docs job dry-run condition * make: remove resolved clippy exceptions * ci: remove redundancy in docs job
Summary of changes
Changes introduced in this pull request:
verify_window_post
Reference issue to close (if applicable)
Closes
Other information and links