-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calibnet Support #1370
Calibnet Support #1370
Conversation
Is Calibnet ready to go? Could you rebase on main? |
No it's not. There are still some sync issues. |
Hey @ec2 helping @connormullett with this sync issue and would like to know if you have some idea why this is failing. Basically everything looks good during the block validation (height 636,822) after importing the snapshot except one call that internally failed. The offending callstack goes like this: forest/blockchain/chain_sync/src/tipset_syncer.rs Line 1366 in b202340
forest/blockchain/state_manager/src/lib.rs Line 657 in b202340
forest/blockchain/state_manager/src/lib.rs Line 1263 in b202340
forest/blockchain/state_manager/src/lib.rs Line 138 in b202340
forest/vm/state_tree/src/lib.rs Line 216 in b202340
forest/vm/actor_interface/src/adt/map.rs Line 39 in b202340
... Line 96 in b202340
To sum up it seems to me that reading using the
Any ideas where this could come from or on how to continue debugging this? Thanks :) |
linter fails on #1438 |
Everything is g2g now. Should not sync past nv15 but doesn't panic |
@@ -389,10 +389,11 @@ where | |||
let deleted = child_node.rm_value(hashed_key, bit_width, depth + 1, key, store)?; | |||
if deleted.is_some() { | |||
*child = Pointer::Dirty(std::mem::take(child_node)); | |||
|
|||
// Clean to retrieve canonical form | |||
child.clean()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be backported to ref-fvm
? If I understand correctly, they have the same issue on their side so calibnet can't work with any implementation using ref-fvm, right? https://github.com/filecoin-project/ref-fvm/blob/lemmih/forest/ipld/hamt/src/node.rs#L396
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I'm going to say yes. I'll open a PR on their side with the same fix and see what they say
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR opened here: filecoin-project/ref-fvm#343
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked for me! great work :D
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #1320
Other information and links
to build:
make calibnet
calibnet snapshot can be made from lotus
Should fail after nv15 as changes are not introduced for the upgrade here