-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'fvm' backend in parallel to our native backend. #1403
Conversation
OpenCL is now a dependency and it is not available on the CI machines, apparently. |
Could you try adding
to the CI? |
MacOS doesn't like that, unsurprisingly. :) |
I've verified that this branch can still sync to mainnet (with updated dependencies, not using the FVM actors). |
The new code makes it more clear that we're blocking in async code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you update the docs or makefile to include rustup target add wasm32-unknown-unknown
? I had to do this to get make release
to work. can you also document the BACKEND=native/fvm/both
env variable somewhere?
Not sure where to document the |
@lemmih makes sense, feel free to leave that out for now then |
panic!("FVM doesn't support older networks") | ||
// self.rand | ||
// .get_chain_randomness_v1(personalization, rand_epoch, entropy) | ||
// .map_err(|e| e.downcast_fatal("could not get randomness"))? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are using BACKEND=native
are the older versions supported? I thought they were still, is that not the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nv14 is supported in this branch - regardless of which backend is used. The native backend could possibly sync from older network versions but not as far back as genesis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, we can prioritize adding the previous versions to the FVM then, since that's handy to have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked for me with nv14! could you remove the commented out code before merging and make issues if needed?
Codecov Report
@@ Coverage Diff @@
## main #1403 +/- ##
==========================================
- Coverage 26.25% 24.27% -1.99%
==========================================
Files 312 311 -1
Lines 23786 23896 +110
==========================================
- Hits 6245 5800 -445
- Misses 17541 18096 +555
Continue to review full report at Codecov.
|
@lemmih seems this got merged filecoin-project/ref-fvm#326, would be nice to use stable here as well. |
.github/workflows/rust.yml
Outdated
@@ -69,7 +70,8 @@ jobs: | |||
- name: Install Toolchain | |||
uses: actions-rs/toolchain@v1 | |||
with: | |||
toolchain: stable | |||
toolchain: nightly-2021-12-14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use stable now? filecoin-project/ref-fvm#326
Or is there anything else missing in stable?
README.md
Outdated
@@ -29,14 +29,17 @@ Our crates: | |||
|
|||
|
|||
## Dependencies | |||
`rustc >= 1.57.0` | |||
`rustc >= nightly-2022-02-14` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, 1.58.1
?
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #1409
Closes #1441
Other information and links
Putting here the link to the Hook up code of the FVM on Lotus.