Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: switch to rust edition 2021 #1429

Merged
merged 1 commit into from
Feb 15, 2022
Merged

rustc: switch to rust edition 2021 #1429

merged 1 commit into from
Feb 15, 2022

Conversation

q9f
Copy link
Contributor

@q9f q9f commented Feb 14, 2022

from 2018

q9f
q9f commented Feb 14, 2022
View reviewed changes
Cargo.lock
@@ -3539,11 +3539,11 @@ dependencies = [

[[package]]
name = "jsonwebtoken"
version = "8.0.1"
version = "7.2.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will never understand what is causing this.

@lemmih
Copy link
Contributor

lemmih commented Feb 14, 2022

CI is failing due to transient network errors.

LesnyRumcajs
LesnyRumcajs reviewed Feb 14, 2022
View reviewed changes
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if it's possible to define this only in the workspace root and let it be propagated without repeating the same setting everywhere?

@q9f
Copy link
Contributor Author

q9f commented Feb 14, 2022

I don't think it's possible because it will always use 2015 as the default unless indicated otherwise.

@LesnyRumcajs
Copy link
Member

I don't think it's possible because it will always use 2015 as the default unless indicated otherwise.

Indeed, seems this is still not implemented. rust-lang/cargo#5784

Hopefully one day we'll get rid of this boilerplate!

@lemmih lemmih merged commit d5a774a into main Feb 15, 2022
@lemmih lemmih deleted the q9f/rust/edition branch February 15, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@lemmih lemmih lemmih approved these changes

@ec2 ec2 Awaiting requested review from ec2

@noot noot Awaiting requested review from noot

@connormullett connormullett Awaiting requested review from connormullett

@elmattic elmattic Awaiting requested review from elmattic

Assignees

@q9f q9f

Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@q9f @lemmih @LesnyRumcajs @lerajk