parametrize current rocksdb settings #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LesnyRumcajs
requested review from
ec2,
noot,
connormullett,
elmattic and
lemmih
as code owners
lemmih
reviewed
Mar 15, 2022
| } | ||
| } | ||
| } | ||
|
|
||
| impl Drop for DBPath { |
There was a problem hiding this comment.
No Drop impl for TempRocksDB?
There was a problem hiding this comment.
Ah, the tempdir is automatically removed when it goes out of scope.
lemmih
approved these changes
Mar 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #1479 +/- ##
==========================================
- Coverage 44.20% 44.17% -0.03%
==========================================
Files 322 322
Lines 28483 28471 -12
==========================================
- Hits 12590 12577 -13
- Misses 15893 15894 +1
Continue to review full report at Codecov.
|
elmattic
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
rocksdbsettings,Other information and links
Part of #1473, more settings and different defaults may come after some tinkering. Doesn't make sense to expose everything at once, there are quite a lot of different knobs available.