Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: simplify os dependencies #1496

Merged
merged 4 commits into from
Mar 24, 2022
Merged

deps: simplify os dependencies #1496

merged 4 commits into from
Mar 24, 2022

Conversation

q9f
Copy link
Contributor

@q9f q9f commented Mar 23, 2022

Just testing if we need all of them.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1496 (8d7e3a7) into main (cf49ba7) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
+ Coverage   44.30%   44.40%   +0.10%     
==========================================
  Files         323      319       -4     
  Lines       28414    28231     -183     
==========================================
- Hits        12588    12537      -51     
+ Misses      15826    15694     -132     
Impacted Files Coverage Δ
blockchain/message_pool/src/msg_chain.rs 80.24% <0.00%> (-0.41%) ⬇️
vm/actor/src/builtin/miner/mod.rs 33.49% <0.00%> (-0.05%) ⬇️
types/src/lib.rs 57.14% <0.00%> (ø)
types/src/sector/post.rs 27.27% <0.00%> (ø)
types/src/randomness.rs
types/src/sector/mod.rs
types/src/sector/registered_proof.rs
encoding/src/bytes.rs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf49ba7...8d7e3a7. Read the comment docs.

@lemmih
Copy link
Contributor

lemmih commented Mar 24, 2022

Looks good. Seems like we didn't need all of those packages.

@q9f q9f marked this pull request as ready for review March 24, 2022 15:10
@lemmih lemmih merged commit e99e378 into main Mar 24, 2022
@lemmih lemmih deleted the q9f/os/deps branch March 24, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants