Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove native smart-contract backend. #1542

Merged
merged 19 commits into from
Jun 21, 2022
Merged

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Jun 20, 2022

Summary of changes
Changes introduced in this pull request:

  • Remove the unused code for the native (non-fvm) execution backend.

Reference issue to close (if applicable)

Other information and links

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #1542 (d76b1e4) into main (d846152) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
+ Coverage   25.61%   25.63%   +0.01%     
==========================================
  Files         289      288       -1     
  Lines       24261    24246      -15     
==========================================
+ Hits         6215     6216       +1     
+ Misses      18046    18030      -16     
Impacted Files Coverage Δ
vm/interpreter/src/vm.rs 0.00% <0.00%> (ø)
blockchain/message_pool/src/msg_chain.rs 80.64% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d846152...d76b1e4. Read the comment docs.

@lemmih lemmih changed the base branch from main to fix-test-build June 20, 2022 14:28
Base automatically changed from fix-test-build to main June 21, 2022 06:44
@lemmih lemmih marked this pull request as ready for review June 21, 2022 07:25
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP, forever in our hearts (and git history) 🕯

Copy link
Contributor

@connormullett connormullett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lemmih lemmih merged commit be7d883 into main Jun 21, 2022
@lemmih lemmih deleted the lemmih/remove-native-backend branch June 21, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants