Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CID-related constants to FVM-owned crates. #1543

Merged
merged 19 commits into from
Jun 21, 2022
Merged

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Jun 20, 2022

Summary of changes
Changes introduced in this pull request:

  • Use shared code from FVM crates.
  • We still need the 'forest_cid' crates due to json support.

Reference issue to close (if applicable)

Other information and links

@lemmih lemmih changed the base branch from main to fix-test-build June 20, 2022 14:28
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@d846152). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1543   +/-   ##
=======================================
  Coverage        ?   25.61%           
=======================================
  Files           ?      289           
  Lines           ?    24261           
  Branches        ?        0           
=======================================
  Hits            ?     6215           
  Misses          ?    18046           
  Partials        ?        0           
Impacted Files Coverage Δ
ipld/cid/src/lib.rs 100.00% <ø> (ø)
ipld/cid/tests/base_cid_tests.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d846152...3ee4366. Read the comment docs.

Base automatically changed from fix-test-build to main June 21, 2022 06:44
@lemmih lemmih marked this pull request as ready for review June 21, 2022 07:26
Copy link
Contributor

@connormullett connormullett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lemmih lemmih merged commit f538c6d into main Jun 21, 2022
@lemmih lemmih deleted the lemmih/remove-cid-impl branch June 21, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants