Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove native implementation of the v6 (nv14) actors. #1559

Merged
merged 12 commits into from
Jun 21, 2022

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Jun 21, 2022

Summary of changes
Changes introduced in this pull request:

  • Removed the DefaultRuntime.
  • Removed the native v6 actor implementation.

Reference issue to close (if applicable)

Closes #1552

Other information and links

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1559 (3406153) into main (8cd7c01) will increase coverage by 13.68%.
The diff coverage is 19.56%.

@@             Coverage Diff             @@
##             main    #1559       +/-   ##
===========================================
+ Coverage   25.61%   39.30%   +13.68%     
===========================================
  Files         289      236       -53     
  Lines       24261    15646     -8615     
===========================================
- Hits         6215     6150       -65     
+ Misses      18046     9496     -8550     
Impacted Files Coverage Δ
blockchain/state_manager/src/vm_circ_supply.rs 0.00% <0.00%> (ø)
ipld/blockstore/src/lib.rs 42.22% <ø> (+13.33%) ⬆️
utils/statediff/src/lib.rs 0.00% <0.00%> (ø)
vm/interpreter/src/default_runtime.rs 0.00% <ø> (ø)
vm/interpreter/src/downcast.rs 0.00% <0.00%> (ø)
vm/interpreter/src/gas_tracker/mod.rs 89.47% <ø> (ø)
vm/interpreter/src/lib.rs 0.00% <ø> (ø)
vm/actor_interface/src/lib.rs 11.53% <33.33%> (-0.47%) ⬇️
vm/actor_interface/src/adt/map.rs 34.21% <36.84%> (-7.17%) ⬇️
vm/state_tree/src/lib.rs 32.71% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cd7c01...3406153. Read the comment docs.

@lemmih lemmih marked this pull request as ready for review June 21, 2022 13:49
utils/statediff/src/lib.rs Show resolved Hide resolved
vm/actor_interface/Cargo.toml Outdated Show resolved Hide resolved
vm/actor_interface/src/adt/map.rs Show resolved Hide resolved
vm/interpreter/src/gas_tracker/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@connormullett connormullett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lemmih lemmih merged commit 3fb6b15 into main Jun 21, 2022
@lemmih lemmih deleted the lemmih/remove-v6-actors branch June 21, 2022 16:10
jdjaustin added a commit that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove native implementation of v6 actors.
3 participants