Subset of Forest Maintenance Tasks (Part 2)

[jdjaustin]

Summary of changes
Changes introduced in this pull request:
To be removed

• Remove all use of Box<dyn Error> in favor of anyhow::Error

Reference issue to close (if applicable)

Closes corresponding task in #1536

Other information and links

N/A

[codecov]

Codecov Report

Merging #1571 (a64753a) into main (20675e6) will decrease coverage by 5.39%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
- Coverage   39.89%   34.50%   -5.40%     
==========================================
  Files         236      207      -29     
  Lines       15902    23378    +7476     
==========================================
+ Hits         6344     8066    +1722     
- Misses       9558    15312    +5754     

Impacted Files	Coverage Δ
blockchain/beacon/src/mock_beacon.rs	23.07% <0.00%> (+8.79%)	⬆️
blockchain/state_manager/src/utils.rs	0.00% <0.00%> (ø)
crypto/src/errors.rs	0.00% <0.00%> (ø)
node/forest_libp2p/src/behaviour.rs	0.00% <0.00%> (ø)
vm/actor_interface/src/adt/array.rs	0.00% <0.00%> (ø)
vm/actor_interface/src/builtin/market/mod.rs	0.00% <ø> (ø)
vm/actor_interface/src/builtin/miner/mod.rs	0.00% <0.00%> (ø)
vm/actor_interface/src/adt/map.rs	37.14% <20.00%> (+2.93%)	⬆️
blockchain/beacon/src/drand.rs	32.77% <30.00%> (+2.21%)	⬆️
types/networks/src/lib.rs	76.59% <100.00%> (+1.59%)	⬆️
... and 253 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20675e6...a64753a. Read the comment docs.

[jdjaustin]

Many occurrences of Box<dyn Error> are aliased as Box<dyn StdError> and changing all these occurrences would probably best be handled under a separate PR, to keep PR sizes manageable. The final occurrences of Box<dyn Error> in map.rs are associated with functions that utilizeBox<dyn StdError>. Will capture this either under a seprate issue or by modifying issue #1536 .

[LesnyRumcajs]

@lemmih is right, I'd extend it to all other places where you changed ? to unwrap. In general, if a method returns a Result, I don't expect it to panic. Please apply here the Principle of least astonishment for poor me. :)

[jdjaustin]

What do you guys suggest instead of using unwrap here? I had to remove the ? due to compiler errors after changing Box<dyn Error> to anyhow::Error. If I leave out .unwrap(), the compiler gives me a warning about an unused Result.

[LesnyRumcajs]

What do you guys suggest instead of using unwrap here? I had to remove the ? due to compiler errors after changing Box<dyn Error> to anyhow::Error. If I leave out .unwrap(), the compiler gives me a warning about an unused Result.

What do you think about .map_err? Have a look at an example here