Refactor chain-specific database location code #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyshko5
changed the title
tyshko5
changed the title
tyshko5
changed the title
lemmih
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1582 +/- ##
==========================================
+ Coverage 34.22% 34.41% +0.19%
==========================================
Files 209 209
Lines 24034 23883 -151
==========================================
- Hits 8225 8219 -6
+ Misses 15809 15664 -145
Continue to review full report at Codecov.
|
tyshko5
requested review from
connormullett,
elmattic,
lemmih,
LesnyRumcajs and
jdjaustin
as code owners
lemmih
approved these changes
Jun 27, 2022
|
Code looks good. Could you add a summary of the changes to the PR? |
lemmih
approved these changes
Jun 27, 2022
LesnyRumcajs
approved these changes
Jun 29, 2022
tyshko5
added a commit
that referenced
this pull request
Jun 29, 2022
* refactor dp path * fix cfg Co-authored-by: tyshkor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
As approach changed from db to chain, I've added chain_path function, so that the single source of truth for various db patches is established. Therefore db_path and sled_path were created
Reference issue to close (if applicable)
Closes #1580
Other information and links