Remove disabled code for handling older actor versions. #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyshko5
requested review from
connormullett,
elmattic,
lemmih,
LesnyRumcajs and
jdjaustin
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1583 +/- ##
==========================================
+ Coverage 34.22% 34.89% +0.67%
==========================================
Files 209 209
Lines 24034 23553 -481
==========================================
- Hits 8225 8219 -6
+ Misses 15809 15334 -475
Continue to review full report at Codecov.
|
lemmih
approved these changes
Jun 27, 2022
| // V5(actorv5::system::State), | ||
| // V6(actorv6::system::State), | ||
| } | ||
| pub enum State {} |
There was a problem hiding this comment.
Do we need it in this form? Empty enum looks quite odd, no?
There was a problem hiding this comment.
It'll eventually be populated and used for pretty-printing the network state.
LesnyRumcajs
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #1581
Other information and links