Get rid of the dirs dependency. #1577 #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyshko5
requested review from
connormullett,
elmattic,
lemmih,
LesnyRumcajs and
jdjaustin
as code owners
lemmih
reviewed
Jun 28, 2022
LesnyRumcajs
approved these changes
Jun 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
- Coverage 34.22% 29.48% -4.74%
==========================================
Files 209 193 -16
Lines 24034 21195 -2839
==========================================
- Hits 8225 6250 -1975
+ Misses 15809 14945 -864
Continue to review full report at Codecov.
|
lemmih
requested changes
Jun 28, 2022
LesnyRumcajs
requested changes
Jun 29, 2022
lemmih
reviewed
Jun 30, 2022
| @@ -34,9 +35,10 @@ pub struct Config { | |||
|
|
|||
| impl Default for Config { | |||
| fn default() -> Self { | |||
| let dir = ProjectDirs::from("com", "ChainSafe", "Forest").expect("failed to find project directories, please set FOREST_CONFIG_PATH environment variable manually."); | |||
There was a problem hiding this comment.
Ideally we would factor this out so we only have a single source of truth for the ProjectDirs. But that can wait until another PR.
lemmih
approved these changes
Jun 30, 2022
LesnyRumcajs
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #1577
Other information and links