Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve pretty-print of BigInt byte values #1593

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

LesnyRumcajs
Copy link
Member

Summary of changes
Changes introduced in this pull request:

  • improved pretty-print of BigInt byte values
  • added unit tests

Reference issue to close (if applicable)

Closes #1589

Other information and links

@LesnyRumcajs LesnyRumcajs force-pushed the pretty-print-bigint branch 2 times, most recently from 29dd374 to af3df53 Compare June 28, 2022 16:08
@LesnyRumcajs LesnyRumcajs force-pushed the pretty-print-bigint branch from af3df53 to 86b8f0a Compare June 28, 2022 16:13
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #1593 (86b8f0a) into main (8a16ea2) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1593      +/-   ##
==========================================
+ Coverage   34.49%   34.59%   +0.10%     
==========================================
  Files         208      208              
  Lines       23384    23413      +29     
==========================================
+ Hits         8066     8100      +34     
+ Misses      15318    15313       -5     
Impacted Files Coverage Δ
forest/src/cli/mod.rs 40.29% <100.00%> (+9.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a16ea2...86b8f0a. Read the comment docs.

Copy link
Contributor

@lemmih lemmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lemmih lemmih merged commit 34aa151 into main Jun 29, 2022
@lemmih lemmih deleted the pretty-print-bigint branch June 29, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve pretty-printing of BigInt byte values.
3 participants