Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fvm-ipld-bitfield #1597

Merged
merged 1 commit into from
Jun 29, 2022
Merged

use fvm-ipld-bitfield #1597

merged 1 commit into from
Jun 29, 2022

Conversation

LesnyRumcajs
Copy link
Member

Summary of changes
Changes introduced in this pull request:

  • Updated all code to use fvm_ipld_bitfield directly.
  • Removed utils/bitfield source code.

Reference issue to close (if applicable)

Closes #1555

Other information and links

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1597 (1acbf5d) into main (df52270) will decrease coverage by 3.25%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1597      +/-   ##
==========================================
- Coverage   34.50%   31.24%   -3.26%     
==========================================
  Files         207      200       -7     
  Lines       23378    21966    -1412     
==========================================
- Hits         8067     6864    -1203     
+ Misses      15311    15102     -209     
Impacted Files Coverage Δ
blockchain/state_manager/src/utils.rs 0.00% <ø> (ø)
node/rpc-api/src/data_types.rs 0.00% <ø> (ø)
node/rpc-api/src/lib.rs 0.87% <ø> (ø)
node/rpc/src/state_api.rs 0.00% <0.00%> (ø)
vm/actor_interface/src/builtin/miner/mod.rs 0.00% <0.00%> (ø)
blockchain/message_pool/src/msgpool/msg_pool.rs 65.55% <0.00%> (-0.20%) ⬇️
blockchain/message_pool/src/msgpool/mod.rs 87.62% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df52270...1acbf5d. Read the comment docs.

@lemmih lemmih merged commit 5fe2b6e into main Jun 29, 2022
@lemmih lemmih deleted the use-fvm-ipld-bitfield branch June 29, 2022 12:48
tyshko5 pushed a commit that referenced this pull request Jun 29, 2022
tyshko5 pushed a commit that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove utils/bitfield in favor of fvm_ipld_bitfield
3 participants