Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate FVM error values. #1604

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Propagate FVM error values. #1604

merged 1 commit into from
Jun 30, 2022

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Jun 29, 2022

Summary of changes
Changes introduced in this pull request:

  • Propagate errors originating in the FVM.

Reference issue to close (if applicable)

Other information and links

Our error handling used to be incompatible with that of the FVM. That was fixed recently so now we can propagate the errors.

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1604 (c1578f9) into main (c475fa5) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1604      +/-   ##
==========================================
+ Coverage   29.40%   29.41%   +0.01%     
==========================================
  Files         194      194              
  Lines       21264    21256       -8     
==========================================
  Hits         6252     6252              
+ Misses      15012    15004       -8     
Impacted Files Coverage Δ
vm/actor_interface/src/builtin/init/mod.rs 0.00% <0.00%> (ø)
vm/actor_interface/src/builtin/market/mod.rs 0.00% <0.00%> (ø)
vm/actor_interface/src/builtin/miner/mod.rs 0.00% <0.00%> (ø)
vm/actor_interface/src/builtin/power/mod.rs 0.00% <0.00%> (ø)
blockchain/message_pool/src/msgpool/utils.rs 53.57% <0.00%> (-7.15%) ⬇️
blockchain/message_pool/src/msgpool/msg_pool.rs 65.75% <0.00%> (+0.19%) ⬆️
blockchain/message_pool/src/msg_chain.rs 86.05% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c475fa5...c1578f9. Read the comment docs.

@lemmih lemmih marked this pull request as ready for review June 30, 2022 08:14
@lemmih lemmih merged commit ce54dba into main Jun 30, 2022
@lemmih lemmih deleted the lemmih/improve-fvm-error-handling branch June 30, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants