bump libp2p #1717
Merged
bump libp2p #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1717 +/- ##
==========================================
- Coverage 28.94% 28.50% -0.44%
==========================================
Files 193 189 -4
Lines 21458 21049 -409
==========================================
- Hits 6210 6001 -209
+ Misses 15248 15048 -200
Continue to review full report at Codecov.
|
LesnyRumcajs
force-pushed
the
bump-libp2p
branch
from
994e4f9 to
6e3995c
Compare
mxinden
reviewed
Jul 26, 2022
There was a problem hiding this comment.
Great to see this happening. Feel free to ping me on this pull request with any questions @LesnyRumcajs .
node/forest_libp2p/src/behaviour.rs
Outdated
| @@ -138,42 +144,42 @@ impl NetworkBehaviourEventProcess<DiscoveryOut> for ForestBehaviour { | |||
| } | |||
| } | |||
|
|
|||
| impl NetworkBehaviourEventProcess<BitswapEvent> for ForestBehaviour { | |||
| impl<P: StoreParams> NetworkBehaviourEventProcess<BitswapEvent> for ForestBehaviour<P> { | |||
There was a problem hiding this comment.
Just as a heads up NetworkBehaviourEventProcess will go away, though that is not yet merged nor released. libp2p/rust-libp2p#2751
LesnyRumcajs
force-pushed
the
bump-libp2p
branch
from
6fadda7 to
b6d678a
Compare
LesnyRumcajs
requested review from
connormullett,
elmattic,
lemmih,
jdjaustin and
tyshko5
as code owners
LesnyRumcajs
force-pushed
the
bump-libp2p
branch
from
6dc6ab1 to
ad6ea5b
Compare
This was referenced Aug 2, 2022
lemmih
approved these changes
Aug 8, 2022
LesnyRumcajs
force-pushed
the
bump-libp2p
branch
from
ace1391 to
7aa3007
Compare
jdjaustin
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
For ease of updating (and given that
libp2p-bitswapstill depends onlibp2p 0.43) I updated the fork we were using. Please review it alongside this PR. ChainSafe/libp2p-bitswap#3Updated
libp2pto0.46.Reference issue to close (if applicable)
Closes #1698
Other information and links