Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nv19 migration #2775

Merged
merged 42 commits into from
Apr 21, 2023
Merged

nv19 migration #2775

merged 42 commits into from
Apr 21, 2023

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Apr 18, 2023 •
edited by LesnyRumcajs
Loading

Summary of changes

Changes introduced in this pull request:

  • Add migration code for nv19
  • Add nv20 Height

Reference issue to close (if applicable)

Closes #2763

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review April 20, 2023 08:25
@elmattic elmattic marked this pull request as draft April 20, 2023 08:27
elmattic and others added 22 commits April 20, 2023 18:20
@LesnyRumcajs LesnyRumcajs force-pushed the elmattic/nv19-migration branch from 4992da8 to 0bedf87 Compare April 20, 2023 16:24
@q9f q9f linked an issue Apr 20, 2023 that may be closed by this pull request
NV19 & NV20 migration #2763
Closed
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review April 20, 2023 19:14
@q9f q9f mentioned this pull request Apr 20, 2023
Merged
4 tasks
@LesnyRumcajs LesnyRumcajs marked this pull request as draft April 20, 2023 21:49
@lemmih lemmih marked this pull request as ready for review April 21, 2023 09:09
@LesnyRumcajs LesnyRumcajs enabled auto-merge (squash) April 21, 2023 09:11
@LesnyRumcajs LesnyRumcajs merged commit c6040e1 into main Apr 21, 2023
@LesnyRumcajs LesnyRumcajs deleted the elmattic/nv19-migration branch April 21, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@lemmih lemmih lemmih approved these changes

@jdjaustin jdjaustin Awaiting requested review from jdjaustin

@hanabi1224 hanabi1224 Awaiting requested review from hanabi1224

@creativcoder creativcoder Awaiting requested review from creativcoder

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NV19 & NV20 migration
3 participants
@elmattic @lemmih @LesnyRumcajs