Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow --config and --chain to be used at the same time #2808

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Apr 28, 2023

Summary of changes

Changes introduced in this pull request:

  • The --config flag and --chain flag must be usable at the same time.
  • The way we handle networks is completely broken. This PR is a band-aid solution.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review April 28, 2023 11:34
@lemmih lemmih merged commit 9d5f097 into main Apr 28, 2023
@lemmih lemmih deleted the lemmih/revert-config-change branch April 28, 2023 12:05
@elmattic
Copy link
Contributor

Maybe also remove the combination_of_following_flags_should_fail test.

@lemmih
Copy link
Contributor Author

lemmih commented Apr 28, 2023

Maybe also remove the combination_of_following_flags_should_fail test.

Oops, right. Could have sworn that the tests all passed.

@lemmih
Copy link
Contributor Author

lemmih commented Apr 28, 2023

Maybe also remove the combination_of_following_flags_should_fail test.

Oops, right. Could have sworn that the tests all passed.

Ah, the test doesn't quite test what you meant it to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants