Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove #[allow(unused, clippy::upper_case_acronyms, clippy::enum_variant_names)] #3011

Merged
merged 25 commits into from
Jun 26, 2023
Merged

fix: remove #[allow(unused, clippy::upper_case_acronyms, clippy::enum_variant_names)] #3011

merged 25 commits into from
Jun 26, 2023

Conversation

aatifsyed
Copy link
Contributor

@aatifsyed aatifsyed commented Jun 19, 2023 •
edited
Loading

Summary of changes

Note that merging this is blocked on other MRs

@aatifsyed aatifsyed mentioned this pull request Jun 16, 2023
Closed
11 tasks
lemmih
lemmih approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@lemmih lemmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanabi1224 Any insight into the libp2p changes?

src/lib.rs Outdated Show resolved Hide resolved
@hanabi1224
Copy link
Contributor

@lemmih I agree that the change is simple and straightforward, however the root cause of last regression is still unknown, I would suggest making the libp2p change in a small PR that is easy to revert in case any regression happens. Does that make sense?

@aatifsyed aatifsyed self-assigned this Jun 19, 2023
@aatifsyed aatifsyed marked this pull request as draft June 19, 2023 13:18
@aatifsyed aatifsyed force-pushed the aatifsyed/one-crate-lints branch 2 times, most recently from 4165cb1 to 6ba8790 Compare June 20, 2023 21:53
@aatifsyed aatifsyed mentioned this pull request Jun 20, 2023
Closed
@aatifsyed aatifsyed force-pushed the aatifsyed/one-crate-lints branch 2 times, most recently from 5a3d6b8 to 40a53be Compare June 21, 2023 09:34
@aatifsyed aatifsyed mentioned this pull request Jun 21, 2023
Merged
@aatifsyed aatifsyed force-pushed the aatifsyed/one-crate-lints branch from 40a53be to f0099fe Compare June 21, 2023 09:43
@aatifsyed aatifsyed marked this pull request as ready for review June 21, 2023 09:48
@aatifsyed aatifsyed changed the title Remove most #[allow(...)] attributes fix: remove #[allow(unused, clippy::upper_case_acronyms, clippy::enum_variant_names)] Jun 21, 2023
@aatifsyed aatifsyed enabled auto-merge (squash) June 21, 2023 09:59
@aatifsyed aatifsyed mentioned this pull request Jun 21, 2023
Merged
@aatifsyed aatifsyed force-pushed the aatifsyed/one-crate-lints branch 4 times, most recently from 4786338 to 6fe2c31 Compare June 26, 2023 10:18
LesnyRumcajs
LesnyRumcajs approved these changes Jun 26, 2023
View reviewed changes
src/beacon/mock_beacon.rs Show resolved Hide resolved
src/shim/machine/manifest.rs Show resolved Hide resolved
@aatifsyed aatifsyed mentioned this pull request Jun 26, 2023
Closed
aatifsyed and others added 25 commits June 26, 2023 12:46
@aatifsyed
feat: unused items removed
aec0845
@aatifsyed
fix: MockBeacon
4a132db
@aatifsyed
fix: HeadChange
8858710
@aatifsyed
fix: json::bigint
7818b0e
@aatifsyed
fix: ipld
2b6dac5
@aatifsyed
fix: wallet
5788028
@aatifsyed
fix: trivial test-only items
d3383be
@aatifsyed
fix: msg_chain and msgpool
bf9d0bf
@aatifsyed
fix: msgpool/test_provider
642b5b7
@aatifsyed
fix: remove dead rpc entrypoints
fb5343e
@aatifsyed
fix: punt api items
986fc2d
@aatifsyed
fix: test_utils is #[cfg(test)], and simpler
9d509ab
@aatifsyed
fix: just allow the actor names
a6906ce
@aatifsyed
fix: file_backed_obj
685f9a7
@aatifsyed
fix: json/go_vec_visitor
cebd969
@aatifsyed
fix: punt removal of visitreason
4c5ead3
@aatifsyed
feat: remove #[allow(clippy::upper_case_acronyms)]
cfb1d59
@aatifsyed
feat: remove #[allow(clippy::enum_variant_names)]
736c251
@aatifsyed
fix: unused fn param in migrator
bcd9f9b
@aatifsyed
fix: remove #[allow(unused)]
c9ca841
@LesnyRumcajs @aatifsyed
parallelize debug/release unit tests (#3073)
4bec3dc
@aatifsyed
chore: fixup new unused code
818a716
@aatifsyed
feat: run clippy on tests
e4244e5
@aatifsyed
review: remove new, and add efault
d763780
@aatifsyed
fix: unused code after remove deleg_cns
d9b5c60
@aatifsyed aatifsyed force-pushed the aatifsyed/one-crate-lints branch from 6e41fb8 to d9b5c60 Compare June 26, 2023 11:58
@aatifsyed aatifsyed merged commit e850e68 into main Jun 26, 2023
@aatifsyed aatifsyed deleted the aatifsyed/one-crate-lints branch June 26, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@lemmih lemmih lemmih approved these changes

@elmattic elmattic Awaiting requested review from elmattic

@jdjaustin jdjaustin Awaiting requested review from jdjaustin

@hanabi1224 hanabi1224 Awaiting requested review from hanabi1224

@creativcoder creativcoder Awaiting requested review from creativcoder

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank

@ruseinov ruseinov Awaiting requested review from ruseinov

Assignees

@aatifsyed aatifsyed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aatifsyed @hanabi1224 @lemmih @LesnyRumcajs