Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Premature end for exported snapshots #3015

Merged
merged 17 commits into from
Jun 20, 2023
Merged

[Fix] Premature end for exported snapshots #3015

merged 17 commits into from
Jun 20, 2023

Conversation

ruseinov
Copy link
Contributor

@ruseinov ruseinov commented Jun 19, 2023

Summary of changes

Changes introduced in this pull request:

  • Properly close ZstdEncoder stream.

Reference issue to close (if applicable)

Closes #3006

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@ruseinov ruseinov enabled auto-merge (squash) June 19, 2023 16:49
@ruseinov
Copy link
Contributor Author

ruseinov commented Jun 19, 2023

Weirdly, this works locally like a charm, but still fails here with the same error. Perhaps this has to do with zstd version, though in theory it should not matter..

EDIT: Fixed, this was caused by the snapshot that's been downloaded for forest startup, which is corrupted like all the other recent snapshots.

scripts/tests/calibnet_export_check.sh Outdated Show resolved Hide resolved
scripts/tests/calibnet_export_check.sh Outdated Show resolved Hide resolved
src/chain/store/chain_store.rs Outdated Show resolved Hide resolved
.github/workflows/forest.yml Outdated Show resolved Hide resolved
@ruseinov ruseinov merged commit 662699f into main Jun 20, 2023
@ruseinov ruseinov deleted the ru/fix/zstd branch June 20, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot files are not valid zstd archives
4 participants