fix: truncated actor bundles #3485

[aatifsyed]

#3485

[aatifsyed]

So the new actor bundle file is 12139433 bytes big? It's almost six time the previous size.

Not surprising - the uncompressed is 60MiB:

#!/usr/bin/env python3

import requests
import humanize

urls = [
    "https://github.com/filecoin-project/builtin-actors/releases/download/v9.0.3/builtin-actors-calibrationnet.car",
    "https://github.com/filecoin-project/builtin-actors/releases/download/v10.0.0-rc.1/builtin-actors-calibrationnet.car",
    "https://github.com/filecoin-project/builtin-actors/releases/download/v11.0.0-rc2/builtin-actors-calibrationnet.car",
    "https://github.com/filecoin-project/builtin-actors/releases/download/v9.0.3/builtin-actors-devnet.car",
    "https://github.com/filecoin-project/builtin-actors/releases/download/v10.0.0/builtin-actors-devnet.car",
    "https://github.com/filecoin-project/builtin-actors/releases/download/v11.0.0/builtin-actors-devnet.car",
    "https://github.com/filecoin-project/builtin-actors/releases/download/v9.0.3/builtin-actors-mainnet.car",
    "https://github.com/filecoin-project/builtin-actors/releases/download/v10.0.0/builtin-actors-mainnet.car",
    "https://github.com/filecoin-project/builtin-actors/releases/download/v11.0.0/builtin-actors-mainnet.car",
]

total = 0

for url in urls:
    response = requests.head(url, allow_redirects=True)
    response.raise_for_status()
    content_length = response.headers["content-length"]
    total += int(content_length)

print(humanize.naturalsize(total, binary=True))

60.4 MiB

[ruseinov]

Looks good and way more readable.
Would be nice to have some details/comments about the car validation though.
it's not really clean why certain assumptions are enforced.

[LesnyRumcajs]

Why don't we need this check anymore?

[aatifsyed]

It's covered by the asset_integrity test now

[lemmih]

Great!