-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove stream seek constraint #3505
Conversation
It's technically possible to craft an uncompressed CAR file which will be identified as a zstd compressed file. However, no valid Filecoin CAR file can be misidentified in this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a test that exercice the non-compressed path?
Added a test using the uncompressed genesis CAR file. |
This PR was merged. |
Summary of changes
Changes introduced in this pull request:
AsyncSeek
constraint forCarStream
. The seek constraint prevents streaming data from, say, an HTTP server.Reference issue to close (if applicable)
Closes
Other information and links
Change checklist