Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove stream seek constraint #3505

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Sep 19, 2023

Summary of changes

Changes introduced in this pull request:

  • Remove AsyncSeek constraint for CarStream. The seek constraint prevents streaming data from, say, an HTTP server.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Cargo.toml Outdated Show resolved Hide resolved
@lemmih
Copy link
Contributor Author

lemmih commented Sep 19, 2023

It's technically possible to craft an uncompressed CAR file which will be identified as a zstd compressed file. However, no valid Filecoin CAR file can be misidentified in this way.

@lemmih lemmih marked this pull request as ready for review September 19, 2023 11:25
@lemmih lemmih requested a review from a team as a code owner September 19, 2023 11:25
@lemmih lemmih requested review from ruseinov and elmattic and removed request for a team September 19, 2023 11:25
Copy link
Contributor

@elmattic elmattic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test that exercice the non-compressed path?

@lemmih
Copy link
Contributor Author

lemmih commented Sep 19, 2023

Do we have a test that exercice the non-compressed path?

Added a test using the uncompressed genesis CAR file.

@lemmih lemmih enabled auto-merge September 19, 2023 12:28
@lemmih lemmih added this pull request to the merge queue Sep 19, 2023
@lemmih lemmih added this pull request to the merge queue Sep 19, 2023
@lemmih lemmih removed this pull request from the merge queue due to a manual request Sep 19, 2023
@lemmih lemmih closed this Sep 19, 2023
@lemmih
Copy link
Contributor Author

lemmih commented Sep 19, 2023

This PR was merged.

Merged via the queue into main with commit 49a10ba Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants