Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] create_migrations macro. #3533

Merged
merged 1 commit into from
Oct 2, 2023
Merged

[Fix] create_migrations macro. #3533

merged 1 commit into from
Oct 2, 2023

Conversation

ruseinov
Copy link
Contributor

@ruseinov ruseinov commented Oct 2, 2023

Summary of changes

Changes introduced in this pull request:

  • Fixes a create_migrations macro bug that caused it to fail with more than one migration

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@ruseinov ruseinov requested a review from a team as a code owner October 2, 2023 13:34
@ruseinov ruseinov requested review from LesnyRumcajs and jdjaustin and removed request for a team October 2, 2023 13:34
@ruseinov ruseinov enabled auto-merge October 2, 2023 13:41
@ruseinov ruseinov added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit a731164 Oct 2, 2023
@ruseinov ruseinov deleted the ru/fix/migration-macro branch October 2, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@lemmih lemmih lemmih approved these changes

@jdjaustin jdjaustin Awaiting requested review from jdjaustin jdjaustin is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruseinov @lemmih @LesnyRumcajs