Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement testing of Filecoin.ChainGetBlockMessages API #3675

Merged
merged 11 commits into from
Nov 8, 2023

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Nov 6, 2023

Summary of changes

Changes introduced in this pull request:

  • Add Filecoin.ChainGetBlockMessages testing in forest-tool api compare

Reference issue to close (if applicable)

Part of #3639

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review November 7, 2023 16:24
@elmattic elmattic requested a review from a team as a code owner November 7, 2023 16:24
@elmattic elmattic requested review from hanabi1224 and sudo-shashank and removed request for a team November 7, 2023 16:24
CHANGELOG.md Outdated Show resolved Hide resolved
src/cli/subcommands/chain_cmd.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@lemmih lemmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: Filecoin.ChainGetBlockMessages now shows up as Valid for both Forest and Lotus?

@lemmih
Copy link
Contributor

lemmih commented Nov 8, 2023

Oh, btw, the PR description needs to be updated.

@lemmih
Copy link
Contributor

lemmih commented Nov 8, 2023

And this PR is part of #3639

@elmattic
Copy link
Contributor Author

elmattic commented Nov 8, 2023

Just to confirm: Filecoin.ChainGetBlockMessages now shows up as Valid for both Forest and Lotus?

Yes, I'm seeing that:

| RPC Method                            | Forest              | Lotus         |
|---------------------------------------|---------------------|---------------|
| Filecoin.ChainGetBlock                | Valid               | Valid         |
| Filecoin.ChainGetBlockMessages        | Valid               | Valid         |
| Filecoin.ChainGetGenesis              | Valid               | Valid         |
...

@lemmih
Copy link
Contributor

lemmih commented Nov 8, 2023

Just to confirm: Filecoin.ChainGetBlockMessages now shows up as Valid for both Forest and Lotus?

Yes, I'm seeing that:

| RPC Method                            | Forest              | Lotus         |
|---------------------------------------|---------------------|---------------|
| Filecoin.ChainGetBlock                | Valid               | Valid         |
| Filecoin.ChainGetBlockMessages        | Valid               | Valid         |
| Filecoin.ChainGetGenesis              | Valid               | Valid         |
...

Excellent!

@elmattic elmattic changed the title feat: implement Filecoin.ChainGetBlockMessages API feat: implement testing of Filecoin.ChainGetBlockMessages API Nov 8, 2023
@elmattic elmattic added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit bec9bf1 Nov 8, 2023
25 checks passed
@elmattic elmattic deleted the elmattic/chain-get-block-messages branch November 8, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants