Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update bitswap to use quick-protobuf to match rust-libp2p #3683

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Nov 7, 2023

Summary of changes

Changes introduced in this pull request:

Manually tested on calibnet, bitswap metrics looks good

# HELP bitswap_get_block_time Duration of get_block
# TYPE bitswap_get_block_time histogram
bitswap_get_block_time_bucket{le="0.1"} 8
bitswap_get_block_time_bucket{le="0.5"} 8
bitswap_get_block_time_bucket{le="0.75"} 9
bitswap_get_block_time_bucket{le="1"} 11
bitswap_get_block_time_bucket{le="1.5"} 11
bitswap_get_block_time_bucket{le="2"} 11
bitswap_get_block_time_bucket{le="3"} 11
bitswap_get_block_time_bucket{le="4"} 11
bitswap_get_block_time_bucket{le="5"} 11
bitswap_get_block_time_bucket{le="6"} 11
bitswap_get_block_time_bucket{le="7"} 11
bitswap_get_block_time_bucket{le="8"} 11
bitswap_get_block_time_bucket{le="9"} 11
bitswap_get_block_time_bucket{le="10"} 11
bitswap_get_block_time_bucket{le="+Inf"} 11
bitswap_get_block_time_sum 2.8556087760000004
bitswap_get_block_time_count 11
# HELP bitswap_message_count Number of bitswap messages
# TYPE bitswap_message_count counter
bitswap_message_count{type="get_block_success"} 11
bitswap_message_count{type="inbound_request_have"} 4
bitswap_message_count{type="inbound_response_block"} 189
bitswap_message_count{type="inbound_response_block_not_requested"} 178
bitswap_message_count{type="inbound_response_block_update_db"} 11
bitswap_message_count{type="inbound_response_have_yes"} 74
bitswap_message_count{type="inbound_stream_count"} 265
bitswap_message_count{type="outbound_request_block"} 3
bitswap_message_count{type="outbound_request_cancel"} 415
bitswap_message_count{type="outbound_request_have"} 413
bitswap_message_count{type="outbound_response_have"} 2
bitswap_message_count{type="outbound_stream_count"} 652

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review November 7, 2023 16:02
@hanabi1224 hanabi1224 requested a review from a team as a code owner November 7, 2023 16:02
@hanabi1224 hanabi1224 requested review from elmattic and aatifsyed and removed request for a team November 7, 2023 16:02
@lemmih lemmih added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit a1e081d Nov 8, 2023
@lemmih lemmih deleted the hm/bitswap-quick-protobuf branch November 8, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants