fix workflows for fork PRs #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LesnyRumcajs
force-pushed
the
fix-fork-workflows
branch
from
605dcca to
e791837
Compare
LesnyRumcajs
force-pushed
the
fix-fork-workflows
branch
from
e791837 to
f9cb36c
Compare
LesnyRumcajs
requested review from
hanabi1224 and
elmattic
and removed request for
a team
hanabi1224
reviewed
Nov 22, 2023
| @@ -15,6 +15,10 @@ on: | |||
| # This needs to be declared explicitly so that the job is actually | |||
| # run when moved out of draft. | |||
| types: [opened, synchronize, reopened, ready_for_review] | |||
| pull_request_target: | |||
There was a problem hiding this comment.
Does this one not need branches?
There was a problem hiding this comment.
For consistency it should, I'll address it in another PR given it's outside of the scope of this one, and I'd like to have an easy way of reverting this if needed.
hanabi1224
approved these changes
Nov 22, 2023
elmattic
approved these changes
Nov 22, 2023
LesnyRumcajs
added a commit
that referenced
this pull request
Nov 23, 2023
This reverts commit b7ac403.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist