Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metric): add forest version to prometheus #4535

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jul 16, 2024

Summary of changes

Changes introduced in this pull request:

  • add forest version to prometheus
# HELP forest_version semantic version of the forest binary
# TYPE forest_version info
forest_version_info{version="0.19.0+git.ffa93120d61"} 1

Reference issue to close (if applicable)

Closes #4533

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review July 16, 2024 13:09
@hanabi1224 hanabi1224 requested a review from a team as a code owner July 16, 2024 13:09
@hanabi1224 hanabi1224 requested review from ruseinov and LesnyRumcajs and removed request for a team July 16, 2024 13:09
@hanabi1224
Copy link
Contributor Author

@LesnyRumcajs oops, sorry that I did not see you self-assigned the issue. If you have mostly done the work, plz feel free to close this one.

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs oops, sorry that I did not see you self-assigned the issue. If you have mostly done the work, plz feel free to close this one.

No worries, I mentally assumed it's a lowest priority that can be and didn't plan to do it today :)

@samuelarogbonlo
Copy link
Contributor

Nice!, thanks Guys.

@lemmih lemmih added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 1103ac7 Jul 17, 2024
31 of 48 checks passed
@lemmih lemmih deleted the hm/forest-version-metric branch July 17, 2024 06:56
LesnyRumcajs added a commit that referenced this pull request Jul 25, 2024
LesnyRumcajs added a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Forest version in Prometheus metrics
4 participants