feat: add unsupported EthGetTransactionByBlock*
#4726
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
unimplemented
stubs forFilecoin.EthGetTransactionByBlockNumberAndIndex
andFilecoin.EthGetTransactionByBlockHashAndIndex
. This behaviour matches Lotus's 1.29.0 behavior, and so we are on par with its support. Given the current Lotus-centric testing infrastructure, I believe that's the optimal way to move forward. When Lotus will decide to implement these methods, we'll get a notification.Reference issue to close (if applicable)
Closes #4701
Closes #4702
Other information and links
https://github.com/filecoin-project/lotus/blob/665cd01a09943f5b7ace541e534c0f2a56b64645/node/impl/full/eth.go#L535C18-L541
Change checklist