Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unsupported EthGetTransactionByBlock* #4726

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Sep 3, 2024

Summary of changes

Changes introduced in this pull request:

  • added unimplemented stubs for Filecoin.EthGetTransactionByBlockNumberAndIndex and Filecoin.EthGetTransactionByBlockHashAndIndex. This behaviour matches Lotus's 1.29.0 behavior, and so we are on par with its support. Given the current Lotus-centric testing infrastructure, I believe that's the optimal way to move forward. When Lotus will decide to implement these methods, we'll get a notification.

Reference issue to close (if applicable)

Closes #4701
Closes #4702

Other information and links

❯ docker compose logs api-compare | rg EthGetTransactionByBlock
api-compare-1  | | Filecoin.EthGetTransactionByBlockHashAndIndex (10)   | Rejected("unsupported method")                                                                | Rejected("unsupported method")                                                                                                                                                                                                                                   |
api-compare-1  | | Filecoin.EthGetTransactionByBlockNumberAndIndex (10) | Rejected("unsupported method")                                                                | Rejected("unsupported method") 

https://github.com/filecoin-project/lotus/blob/665cd01a09943f5b7ace541e534c0f2a56b64645/node/impl/full/eth.go#L535C18-L541

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the eth-get-transaction-by-block-number-and-index branch from d2e4b13 to 4135950 Compare September 3, 2024 15:29
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review September 3, 2024 15:30
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner September 3, 2024 15:30
@LesnyRumcajs LesnyRumcajs requested review from ruseinov and sudo-shashank and removed request for a team September 3, 2024 15:30
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 98d4f34 Sep 4, 2024
33 of 52 checks passed
@LesnyRumcajs LesnyRumcajs deleted the eth-get-transaction-by-block-number-and-index branch September 4, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EthGetTransactionByBlockNumberAndIndex EthGetTransactionByBlockHashAndIndex
3 participants