-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): implement EthGetTransactionByBlockNumberAndIndex #5030
feat(rpc): implement EthGetTransactionByBlockNumberAndIndex #5030
Conversation
You have some CI error: | Filecoin.EthGetTransactionByBlockNumberAndIndex (5) | Rejected("index 0 out of range: tipset contains 0 messages") | Rejected("failed to get transaction at index 0: index 0 out of range: tipset contains 0 messages") The failure is likely due to this identity test using the policy |
Lotus method implementation is accepting values like "latest", "pending", etc? (see filecoin-project/lotus#12618 (comment)) What about us? |
@virajbhartiya can you put the PR back to draft and only turn it to RFR when CI is ✅? Thanks! In general, no green checkmark => no review. |
https://www.quicknode.com/docs/ethereum/eth_getTransactionByBlockNumberAndIndex According to the specification, the method accepts only a string in hexadecimal format or tags for the block number. We can also support this by using a type like:
Then we can create a conversion function to build a Of course, we can choose to diverge from the Ethereum specification (and to what is implemented in Lotus), but this would complicate our efforts to align with a common OpenRPC standard. See filecoin-project/FIPs#1027. edit: Actually, we already have similar type implemented, it's called |
CHANGELOG.md
Outdated
@@ -80,6 +80,11 @@ methods, fixes (notably to the garbage collection), and other improvements. | |||
- [#4701](https://github.com/ChainSafe/forest/issues/4701) Add support for the | |||
`Filecoin.EthGetTransactionByBlockHashAndIndex` RPC method. | |||
|
|||
- [#5020](https://github.com/ChainSafe/forest/issues/5020) Add support for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this needs to be moved to under Forest unreleased
section
Summary of changes
Changes introduced in this pull request:
implement EthGetTransactionByBlockNumberAndIndex
Reference issue to close (if applicable)
Closes #5020
Other information and links
Change checklist