fix(rpc): StateCirculatingSupply #5090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
requested review from
lemmih and
elmattic
and removed request for
a team
hanabi1224
commented
Dec 17, 2024
| @@ -1542,7 +1542,8 @@ impl RpcMethod<1> for StateCirculatingSupply { | |||
| let height = ts.epoch(); | |||
| let root = ts.parent_state(); | |||
| let genesis_info = GenesisInfo::from_chain_config(ctx.chain_config().clone()); | |||
| let supply = genesis_info.get_state_circulating_supply(height, &ctx.store_owned(), root)?; | |||
| let supply = | |||
| genesis_info.get_state_circulating_supply(height - 1, &ctx.store_owned(), root)?; | |||
There was a problem hiding this comment.
func (a *StateAPI) StateCirculatingSupply(ctx context.Context, tsk types.TipSetKey) (abi.TokenAmount, error) {
ts, err := a.Chain.GetTipSetFromKey(ctx, tsk)
if err != nil {
return types.EmptyInt, xerrors.Errorf("loading tipset %s: %w", tsk, err)
}
sTree, err := a.StateManager.ParentState(ts)
if err != nil {
return types.EmptyInt, err
}
return a.StateManager.GetCirculatingSupply(ctx, ts.Height()-1, sTree)
}
elmattic
approved these changes
Dec 17, 2024
| @@ -1542,7 +1542,8 @@ impl RpcMethod<1> for StateCirculatingSupply { | |||
| let height = ts.epoch(); | |||
| let root = ts.parent_state(); | |||
| let genesis_info = GenesisInfo::from_chain_config(ctx.chain_config().clone()); | |||
| let supply = genesis_info.get_state_circulating_supply(height, &ctx.store_owned(), root)?; | |||
| let supply = | |||
| genesis_info.get_state_circulating_supply(height - 1, &ctx.store_owned(), root)?; | |||
lemmih
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
See #4968
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #4968
Other information and links
Change checklist