Implement uint128 field encoding for genesis. #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arijitAD
requested review from
EclesioMeloJunior,
edwardmack,
jimjbrettj,
noot and
timwu20
as code owners
edwardmack
approved these changes
Aug 16, 2021
lib/genesis/pallet.go
Outdated
| MaxMembers uint32 `json:"MaxMembers"` //TODO: figure out the type | ||
| Members []string `json:"Members"` | ||
| Pot *scale.Uint128 `json:"Pot"` | ||
| MaxMembers *scale.Uint128 `json:"MaxMembers"` // TODO: figure out the type |
arijitAD
force-pushed
the
impl-uint128-genesis
branch
from
e12ba31 to
c31ed4d
Compare
arijitAD
force-pushed
the
impl-uint128-genesis
branch
from
c31ed4d to
37377d4
Compare
Codecov Report
@@ Coverage Diff @@
## development #1732 +/- ##
============================================
Coverage 58.85% 58.85%
============================================
Files 183 183
Lines 19267 19276 +9
============================================
+ Hits 11339 11345 +6
+ Misses 5965 5963 -2
- Partials 1963 1968 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
|
timwu20
approved these changes
Aug 17, 2021
EclesioMeloJunior
requested changes
Aug 17, 2021
pkg/scale/uint128.go
Outdated
| // UnmarshalJSON converts data to Uint128. | ||
| func (u *Uint128) UnmarshalJSON(data []byte) error { | ||
| buf := make([]byte, len(data)) | ||
| copy(buf, data) |
There was a problem hiding this comment.
the buf variable is not being used
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
timwu20
pushed a commit
to timwu20/gossamer
that referenced
this pull request
Dec 6, 2021
* Implement uint128 field encoding for genesis. * Address comments and fix failing tests. * Fix failing tests. * Remove unused buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Issues
Primary Reviewer