chore(tests): use mockery constructors to ensure assertions #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/mockery-v2.12.1
branch
2 times, most recently
from
c6130b5 to
07a6e7e
Compare
qdm12
force-pushed
the
qdm12/mockery-v2.12.1
branch
from
07a6e7e to
70fe90b
Compare
qdm12
force-pushed
the
qdm12/mockery-v2.12.1
branch
from
70fe90b to
636d8ff
Compare
qdm12
force-pushed
the
qdm12/mockery-v2.12.1
branch
from
636d8ff to
c28019c
Compare
qdm12
changed the title
This was referenced Jul 8, 2022
qdm12
force-pushed
the
qdm12/mockery-v2.12.1
branch
10 times, most recently
from
c3c777e to
410b1dc
Compare
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
qdm12
force-pushed
the
qdm12/mockery-v2.12.1
branch
2 times, most recently
from
cc6bc64 to
d48da71
Compare
qdm12
commented
Aug 19, 2022
lib/babe/babe.go
Outdated
Comment on lines
172
to
175
| if cfg.BlockImportHandler == nil { | ||
| return nil, errNilBlockImportHandler | ||
| } | ||
|
|
There was a problem hiding this comment.
Note this is removed to allow to have nil block import handler in test code.
Anyway imo this check shouldn't be there, and we should panic if we try to pass a nil handler.
Comment on lines
-65
to
-76
| if cfg == nil { | ||
| cfg = &ServiceConfig{ | ||
| Authority: true, | ||
| } | ||
| } | ||
|
|
||
| cfg.BlockImportHandler = new(mocks.BlockImportHandler) | ||
| cfg.BlockImportHandler.(*mocks.BlockImportHandler). | ||
| On("HandleBlockProduced", | ||
| mock.AnythingOfType("*types.Block"), mock.AnythingOfType("*storage.TrieState")). | ||
| Return(nil) | ||
|
|
There was a problem hiding this comment.
note this is pushed back up to the caller (tests), since it was differing from one test to the other.
jimjbrettj
approved these changes
Aug 19, 2022
qdm12
force-pushed
the
qdm12/mockery-v2.12.1
branch
from
d48da71 to
e4706b2
Compare
- Add missing lock calls - Move wrongly placed calls - Rename `changedLock` to `observerListMutex`
qdm12
force-pushed
the
qdm12/mockery-v2.12.1
branch
from
e4706b2 to
53b057b
Compare
edwardmack
approved these changes
Sep 2, 2022
qdm12
added a commit
that referenced
this pull request
Sep 6, 2022
- Use generated mockery constructors for mockery mocks to ensure assertions are done in the test - Fix bugs caused by the now-fixed mock assertions - Remove existing `.Assert*` mock method calls - Fix data race in storage observers
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.Assert*mocks callsTests
All unit tests passing
Issues
Primary Reviewer
@EclesioMeloJunior