enhancement(pkg/scale): remove sorting logic from encodeMap method #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axaysagathiya
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
qdm12
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2904 +/- ##
===============================================
- Coverage 63.09% 63.09% -0.01%
===============================================
Files 219 219
Lines 27590 27585 -5
===============================================
- Hits 17408 17404 -4
+ Misses 8570 8569 -1
Partials 1612 1612 |
|
oh, thanks for letting me know. |
qdm12
changed the title
timwu20
approved these changes
Nov 1, 2022
qdm12
force-pushed
the
changes_in_PR-2894
branch
from
b09baf6 to
a20832f
Compare
|
@axaysagathiya feel free to squash and merge (if you are allowed to? 🤔) |
|
He doesn't have permissions to merge. I can merge it. |
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
Primary Reviewer
@timwu20