chore(proto): fixes and CI check #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/proto
branch
2 times, most recently
from
10afac6 to
528315b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2992 +/- ##
===============================================
- Coverage 52.08% 51.81% -0.28%
===============================================
Files 220 220
Lines 27716 27716
===============================================
- Hits 14436 14360 -76
- Misses 12043 12125 +82
+ Partials 1237 1231 -6 |
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
make protowas not working, found whilst reviewing feat(dot/sync): Remove theEndBlockHashfromBlockRequestMessage#2977go generateto generate Go code from proto fileprotocrequirement when runningmake protoTests
Issues
Primary Reviewer
@EclesioMeloJunior