feature (dot/network): add CLI flag --node-key, hex encoded libp2p node key #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #3043 +/- ##
===============================================
+ Coverage 51.42% 51.43% +0.01%
===============================================
Files 219 219
Lines 28009 28025 +16
===============================================
+ Hits 14403 14415 +12
- Misses 12320 12323 +3
- Partials 1286 1287 +1 |
qdm12
reviewed
Jan 13, 2023
edwardmack
force-pushed
the
ed/zombienet_testing
branch
from
505828c to
7bbed01
Compare
|
Closing this PR because code for this PR was implemented in PR #3098. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces code that implements CLI flag
--node-keywhich allows the user to pass in the secret Ed25519 key to use for libp2p networking. The value is parsed as a hex-encoded Ed25519 secret key, i.e. 64 hex characters. The node then uses that key for libp2p networking. Warning, secrets provided as command-line arguments are easily exposed, so use of this option should be limited to development and testing. This was introduced to enable setting this key in a manner that is used by ZombieNet (https://github.com/paritytech/zombienet) testing framework.Issues
Work done researching issue #2843.
Primary Reviewer
@timwu20