chore(dot/network): added common request-response protocol #3334
+244
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishansagathiya
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
dimartiro and
kanishkatn
as code owners
kishansagathiya
changed the title
kishansagathiya
changed the title
EclesioMeloJunior
requested changes
Jun 20, 2023
EclesioMeloJunior
requested changes
Jun 20, 2023
EclesioMeloJunior
approved these changes
Jun 21, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #3334 +/- ##
===============================================
- Coverage 51.52% 51.44% -0.08%
===============================================
Files 224 225 +1
Lines 28111 28117 +6
===============================================
- Hits 14484 14465 -19
- Misses 12242 12267 +25
Partials 1385 1385 |
jimjbrettj
reviewed
Jun 27, 2023
jimjbrettj
approved these changes
Jun 27, 2023
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
Primary Reviewer
@EclesioMeloJunior