chore(dot/parachain): rename statement #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3281) Co-authored-by: Eclésio Junior <[email protected]> Co-authored-by: Edward Mack <[email protected]>
Co-authored-by: Kishan Sagathiya <[email protected]>
Co-authored-by: Kishan Mohanbhai Sagathiya <[email protected]>
…ement/1 protocol (#3354) - Added `StatementFetchingRequest` and `StatementFetchingResponse` varying data types. - implemented 'network.Message` interface in `StatementFetchingRequest` and 'network.ResponseMessage` interface in `StatementFetchingResponse` as they will be passed into `func (rrp *RequestResponseProtocol) Do(to peer.ID, req Message, res ResponseMessage) error` function as `req` and `res`. - I didn't want to create a new YAML file here. so I decided to rename the YAML file name and variable(in which data of the YAML file getting unmarshalled) name so that I can use them in this PR.
…collation/1 protocol (#3356)
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
…available_data/1 protocol (#3368) - Added AvailableDataFetchingRequest and AvailableDataFetchingResponse types. - Implemented 'network.Message' interface in AvailableDataFetchingRequest and 'network.ResponseMessage' interface in AvailableDataFetchingResponse as they will be passed into this function as req and res.
…g statement and collation (#3374) added New() method and decode test for below varying data types. - statement - statement distribution message - collation protocol - collator protocol message
…pov/1 protocol (#3365) - Added PoVFetchingRequest and PoVFetchingResponse types. - Implemented 'network.Message' interface in PoVFetchingRequest and 'network.ResponseMessage' interface in PoVFetchingResponse as they will be passed into this function as req and res.
#3277) - Added parachain service - Registered collation and validation protocol - Confirmed that we can communicate with collators by talking to them in `run()` function
Implemented following parachain host runtime calls - ParachainHost_persisted_validation_data - ParachainHost_validation_code
This commit adds all the functions required for parachain candidate validations. With this commit, we are able to take candidate receipts and - get validation data for it, - perform basic checks on it, - run respective parachain's validate_block on parachain's runtime, - get validate results from parachain's runtime and verify those validation results again relaychain runtime, - and declare candidate as valid or invalid in the end. This commit also includes tests for candidate validation.
…3382) Co-authored-by: Kanishka <[email protected]> Co-authored-by: Kishan Mohanbhai Sagathiya <[email protected]> Co-authored-by: Axay Sagathiya <[email protected]>
#3427) Co-authored-by: Kishan Sagathiya <[email protected]>
User wazero runtime instance instead of wasmer runtime instance
axaysagathiya
requested review from
EclesioMeloJunior,
jimjbrettj,
kishansagathiya,
dimartiro and
kanishkatn
as code owners
axaysagathiya
changed the title
jimjbrettj
approved these changes
Sep 5, 2023
EclesioMeloJunior
approved these changes
Sep 6, 2023
kishansagathiya
approved these changes
Sep 7, 2023
edwardmack
approved these changes
Sep 8, 2023
timwu20
force-pushed
the
feat/parachain
branch
from
00646bc to
33e9f9a
Compare
…ssamer into axay/chore/rename-statement
Codecov Report
@@ Coverage Diff @@
## feat/parachain #3470 +/- ##
==================================================
+ Coverage 49.61% 49.86% +0.25%
==================================================
Files 244 244
Lines 29403 29403
==================================================
+ Hits 14588 14662 +74
+ Misses 13256 13182 -74
Partials 1559 1559 |
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 23, 2024
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 24, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 15, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
edwardmack
pushed a commit
that referenced
this pull request
Jun 26, 2024
edwardmack
pushed a commit
that referenced
this pull request
Jul 12, 2024
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Polkadot has two types with the same name
Statement.In our code, we have named the enum Statement as
Statementand struct Statement asSignedFullStatementNow the issue is Polkadot also has a struct named
SignedFullStatement.So to avoid confusion I have renamed
StatementtoStatementVDT(type: enum) andSignedFullStatementtoStatement(type: struct)SignedFullStatementwill be added in the future.Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
Primary Reviewer
@kishansagathiya @edwardmack @kanishkatn